Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Injected Universal Provider #3177

Merged
merged 20 commits into from
Dec 17, 2024
Merged

feat: Injected Universal Provider #3177

merged 20 commits into from
Dec 17, 2024

Conversation

ganchoradkov
Copy link
Member

Description

Please include a brief summary of the change.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1db548b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-core Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 4:23pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 4:23pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 4:23pm
appkit-vue-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 4:23pm
appkit-wagmi-cdn-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 4:23pm
vue-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 4:23pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 4:23pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 341.95000000000005% 4520 / 18806
🔵 Statements 341.95000000000005% 4520 / 18806
🔵 Functions 376.05% 372 / 1089
🔵 Branches 463.35% 684 / 1400
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/exports/index.ts 0% 0% 0% 0% 1-23
packages/appkit/src/client.ts 76.41% 74.5% 85.36% 76.41% 101-102, 108-110, 125-126, 129-130, 145-148, 151-154, 157-158, 187-198, 201-208, 303, 311, 349-352, 358-365, 368, 463-475, 490-493, 500-501, 511-512, 527-528, 531-532, 535-536, 539-540, 549-551, 557-564, 581-584, 624, 633-645
packages/appkit/src/library/react/index.ts 0% 0% 0% 0% 1-175
packages/appkit/src/universal-adapter/client.ts 50.45% 43.54% 45.94% 50.45% 118-122, 143-147, 151-152, 155, 160-161, 163-165, 177-181, 183-236, 249-251, 260-274, 290-306, 309-315, 317-323, 333-338, 341-345, 361, 374-379, 383-388, 395-417, 422-424, 426-429, 435-463, 480-488, 516-517, 519, 524-525, 547-548, 560-569, 572-575, 579-607, 646-650, 655-658, 675-676, 688-713, 730-737
packages/appkit/src/utils/TypesUtil.ts 100% 100% 100% 100%
packages/core/src/controllers/ChainController.ts 67.86% 59.37% 69.69% 67.86% 77-80, 83-87, 90-107, 115-116, 143-155, 159-167, 190-191, 233-243, 248-249, 269-270, 274-279, 282-297, 300-303, 314-319, 322-323, 328-329, 332-333, 348-353, 356-357, 362-363, 366-367, 383-384, 389-390, 402-403, 436-444, 447-448, 451-452, 491-492, 511-514, 537-538
packages/core/src/controllers/ConnectionController.ts 42.51% 63.15% 29.62% 42.51% 83-87, 94-95, 101-131, 154-156, 159-175, 178-179, 182-183, 186-187, 190-191, 194-195, 198-199, 202-203, 206-207, 210-211, 214-215, 236-237, 240-242, 245-246, 249-250, 253-254, 261-267, 273-274, 288-294, 299-300, 305-331
packages/core/src/controllers/RouterController.ts 56.79% 100% 62.5% 56.79% 117-118, 125-162, 201-208
packages/scaffold-ui/exports/index.ts 0% 0% 0% 0% 1-120
packages/scaffold-ui/src/modal/w3m-router/index.ts 0% 0% 0% 0% 1-195
packages/scaffold-ui/src/partials/w3m-connecting-wc-qrcode/index.ts 0% 0% 0% 0% 1-110
packages/scaffold-ui/src/partials/w3m-header/index.ts 0% 0% 0% 0% 1-329
packages/scaffold-ui/src/views/w3m-connecting-wc-basic-view/index.ts 0% 0% 0% 0% 1-40
packages/scaffold-ui/src/views/w3m-connecting-wc-view/index.ts 0% 0% 0% 0% 1-208
Generated in workflow #7217 for commit 98fab2a by the Vitest Coverage Report Action

enesozturk
enesozturk reviewed Dec 17, 2024
View reviewed changes
packages/core/src/controllers/OptionsController.ts Outdated
* Enable manual control of WalletConnect connections.
* @default false
*/
useInjectedUniversalProvider?: boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's internal only, we might need to move it from this object since user's will see it and might try to use it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, nice catch

@tomiir tomiir merged commit 3cf3bc5 into main Dec 17, 2024
19 checks passed
@tomiir tomiir deleted the feat/appkit-light branch December 17, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomiir tomiir tomiir left review comments

@magiziz magiziz magiziz approved these changes

@svenvoskamp svenvoskamp svenvoskamp approved these changes

@enesozturk enesozturk enesozturk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ganchoradkov @enesozturk @tomiir @svenvoskamp @magiziz